feat: add nethsupport UI on port 8443 with automatic firewall rules#1565
Closed
feat: add nethsupport UI on port 8443 with automatic firewall rules#1565
Conversation
stephdl
force-pushed
the
sdl-1542-nginx-custom-port
branch
2 times, most recently
from
1643308 to
12a1e9c
Compare
- Add support for netlsupport-specific nginx instance on port 8443 - Automatically activate/deactivate UI when don service starts/stops - Configure firewall zone 'don' for tunDON interface - Create firewall rule to allow port 8443 from VPN tunnel to LAN - Refactor ns-ui script to support multiple custom ports via function - Use same SSL certificate and backend API as main UI When don start is executed: - Enables port 8443 for nethsupport UI - Creates firewall zone for tunDON interface - Creates accept rule for port 8443 from don zone When don stop is executed: - Disables port 8443 - Removes firewall rules and zone
Since we now call /usr/sbin/ns-ui directly in the don script, we no longer need the reload_service() function in the init script. This simplifies the code and avoids an unnecessary layer of indirection.
stephdl
force-pushed
the
sdl-1542-nginx-custom-port
branch
from
ee14c4d to
99300f8
Compare
Member
|
Thanks for the work on this POC. I’ve reviewed it and while it works in some scenarios, it doesn’t fully solve the problem:
Given that the current implementation is quite complex but still incomplete, I’d prefer to close this PR and postpone the work for now. Edoardo is also exploring a full replacement of current remote support, so it makes sense to revisit this later with a cleaner approach. We can keep the issue open for future implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When don start is executed:
When don stop is executed:
#1542